Changelog - April 17 through April 23
We cut another Enterprise release on April 11th, as promised a couple weeks ago. See the Enterprise Changelog for more info!
Code Review Experience
It's now harder to accidentally delete your whole comment with images
I mean, you can always Ctrl-A+Del, but Ctrl-Z is an unsung hero, after all. Well, previously if you selected text in your comment (or the whole thing!) and then uploaded an image in one of the many ways possible, we would clear our the selected text. Since we then do a series of (usually) quick operations, and update the newly-pasted text every time, it's hard to use Ctrl-Z without losing the uploaded image, too. Good news was that those text operations helped you deal with network connectivity issues, and the better news is you don't need to be quick on the draw with Ctrl-Z to save your comment from image uploads.
Thanks to @mkow for reporting this issue and working with me to narrow down the problem!
TL;DR: Dropping an image into a comment box will no longer replace text, only append on the end! Also, don't get me started on network connectivity issues...
Repeated, but even better now: Improved performance for > 1k changed files
We've started working on improving our performance for larger PR's, with the goal of handling any size PR. If you have a PR too big for us, please report it to support@reviewable.io (or file an issue) and we'll add it to the tracker!
So far, we've made PR's with over 1 thousand changed files load a few seconds faster (50-75% faster!).
New this week, if the PR has many reverted files, but only a few non-reverted files, we used to try to show all the files, including the reverted ones, and browsers would become unhappy with the data and rendering work they were shouldered with. Now we'll show them one at a time (you can mark all the reverted files as viewed in the Reverted group in the file matrix).
Minimum line count for collapsing is back to 8
You should no longer see something this annoying! This bug was introduced last November, sorry for letting it slip for so long!
Dashboard Experience
Avatar highlighting!
We've been moving avatars and changing icons around a lot recently, and we've been hearing a lot of feedback about it. Thank you to @outofforrest for initiating the feedback and to @ysv, @bitdancer, and even @silverspase, @miladz68, and @dzmitryhil for upvoting! We could never have made the product as useful as it is without feedback from you all!
Based on that feedback, we added avatar highlighting to the dashboard!
Now you can click on any avatar in the dashboard to "quick filter" the rows to and avatars to highlight the ones with that person's involvement, in that column. For example, if you highlight an avatar in the author column, we will highlight only rows where that user is an author as well.
Bug fixes and performance improvements
I don't like this section either, but I also don't want to highlight things above that you can't see/use, so we'll both just have to sit here and deal it (well, you can close the tab, but I'm going to pretend you care.)
- If you hit a keyboard shortcut to go to a UI element that's not visible (such as the File Matrix, but you ctrl-clicked a file to open it alone), we don't throw errors into the console.
- The performance fix from last week added a corner case around file groups which we reverted quickly, so this week's fix is robust to that.
- Fixed a corner case around not-logged-in users
- And another rare race condition when you go from the dashboard to a specific comment in a PR (no link on that page does that)