Changelog - May 15 through May 21
We just released our May Enterprise release, if you would like more information about that visit our Enterprise README or contact us at sales@reviewable.io
As a result, the work mentioned in this changelog is mainly initial work for larger changes, and a bunch of small bug fixes.
Code Review Experience
Upcoming: Merge queue support
GitHub Enterprise just launched a merge queue feature (it's in public beta at the moment), where instead of merging PR's directly they're put into a group of PR's that are merged as a group. This can be useful in a few scenarios, such as a larger organization with many contentious files that are written to by many engineers at the same time, to reduce the need to cycle between attempting to merge, finding out you can't because Alice just merged her PR, rebasing, (optional) running your CI pipeline again, attempting to merge again and finding out that Bob just merged his PR!
You can read more about GitHub's merge queue feature in their documentation.
Online Subscriptions
Upcoming: Improved Stripe integration
This is a bit of inside baseball, but we're updating how we do trials with Stripe so we can update to the latest Stripe API version and use their newer features, which will simplify the process for signing up and getting receipts/invoices, and also streamline our support process for when something goes wrong. You won't see the benefits of this for a while, this touches a lot of our backend code, but once it's user-visible I'll have another post on it.
Bug fixes and performance improvements
Okay, I keep hating on this section, then I keep including it. Feel free to open an issue if you're as upset with me as I am with myself!
- Dealt with a Safari crash where localStorage is disallowed when we're on the dashboard.
- When signed out, you can still look at public PR's, but you can't comment, so we disabled some comment-related features like quoting text and code.
- Sometimes
setTimeout(..., 0)takes a long time on some browsers, so we short-circuit it in a few places where we don't actually need to delay the function call. - Fixed a rare race-condition where we try to focus a code editor while it's being destroyed (likely through a keyboard shortcut).
- Fixed a rare condition (not a race, this time, just rare) where a draft discussion gets itself into a bad state and causes a review to never finish loading. Thank you to @kajoban for reporting the issue and working with us to get our engineers enough information to fix this.