Comment intents

A Reviewable post written by Piotr Kaminski.By: Piotr Kaminski
Published: Saturday, May 14, 2016

Today the default "discussing" disposition becomes more intuitive and powerful:

image

  1. Comments sent by reviewers now default to being "not OK", so the reviewee can't simply acknowledge the discussion away.

  2. You can start a comment with OK (or LGTM) to accept the outcome and (usually) resolve the discussion.

  3. You can start a comment with FYI (or BTW) to avoid affecting a discussion's resolution state, e.g., to comment on a resolved discussion or make a comment that won't block merging.

This gives you direct control over your "OK / not OK" status and reduces the need to use the explicit "satisfied" and "blocking" dispositions, reserving them for exceptional circumstances.

Do you have ideas for other keywords or "discussion intents"? Send them my way!