Discussion semantics overhaul

A Reviewable post written by Piotr Kaminski.By: Piotr Kaminski
Published: Sunday, May 27, 2018

The new streamlined discussion semantics have landed! In summary:

The Discussing disposition becomes simply "I'm not gonna resolve it, but you're welcome to". Resolution is driven solely by dispositions; the invisible state that determined "OK" and "Not OK" is gone. Comment prefixes (such as "FYI") now just change the disposition. Disposition changes and acknowledgements must be published to commit them, even if made without a corresponding comment. A new Working disposition lets you block a discussion and mark it as something you need to come back to. A new Informing disposition lets you start a resolved discussion that will reach everyone.

For more details, please refer to the spec in issue #510. While I did my best to minimize the disruption for reviews in progress, or for reviews accessed by people with a mix of old and new clients, some bumps are inevitable. Old vs new clients will see some differences: you can expect "to reply" counts to change, pending reviewers to be updated, some old dispositions to be adjusted, etc. In principle, the resolution state of discussions shouldn't change, but it's entirely possible I missed some corner cases. My apologies in advance, but trust me, the end goal is worth it!

As always, please eagerly report any bugs or weird state (even if you don't have a perfect repro) and I'll address them ASAP.