Two small updates related to GitHub review approvals:
The sample review completion condition for evaluating GitHub approvals was broken — sorry! I fixed it, but if you used it as a template for your own you'll want to replace all uses of filter
with where
.
If, on the other hand, you're happy with your LGTM-driven workflow and don't want to use GitHub approvals at all, you can now turn off the "Approve" and "Request changes" options in Reviewable's UI by includingdisableGitHubApprovals: true
in the return value of your custom review completion condition.