Improved review status when publishing

A Reviewable post written by Piotr Kaminski.By: Piotr Kaminski
Published: Monday, June 11, 2018

The review status inserted into your message when you publish is now the same as the one computed for the commit status message, and also includes the list of people being waited on. If you've set up a custom review completion condition then its output will be used automatically.

Previously, the review status was computed by some special-cased hardcoded logic. It was tricky to update it to use the common code path because the status needs to be computed before the changes being published are committed, to enable recovery from partial failures.